Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support EBS vol encryption in default launch template #1235

Merged
merged 3 commits into from
Jan 29, 2022

Conversation

BryanStenson-okta
Copy link
Contributor

@BryanStenson-okta BryanStenson-okta commented Jan 28, 2022

1. Issue, if available:

2. Description of changes:

3. How was this change tested?
make test

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Jan 28, 2022

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 0517b4a

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61f48c3614349e0007884679

Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but @bwagner5 will understand the implications better than me.

@BryanStenson-okta BryanStenson-okta changed the title WIP: support EBS vol encryption in default launch template support EBS vol encryption in default launch template Jan 28, 2022
@BryanStenson-okta BryanStenson-okta changed the title support EBS vol encryption in default launch template WIP: support EBS vol encryption in default launch template Jan 28, 2022
@BryanStenson-okta
Copy link
Contributor Author

looks like deviceName needs to be specified in the BlockDeviceMappings (despite being described as "optional").

@bwagner5 bwagner5 self-requested a review January 28, 2022 21:57
@BryanStenson-okta BryanStenson-okta changed the title WIP: support EBS vol encryption in default launch template support EBS vol encryption in default launch template Jan 29, 2022
@BryanStenson-okta
Copy link
Contributor Author

ok, i've finally verified this works via manual integration testing. good to merge! :)

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for this! 🚀

@bwagner5 bwagner5 merged commit 2cd2e58 into aws:main Jan 29, 2022
@BryanStenson-okta BryanStenson-okta deleted the adding-ebs-encryption branch January 31, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants