-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support EBS vol encryption in default launch template #1235
Conversation
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 0517b4a 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61f48c3614349e0007884679 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but @bwagner5 will understand the implications better than me.
98413a1
to
2b55f3d
Compare
… root volumes of nodes launched
2b55f3d
to
d251d20
Compare
looks like deviceName needs to be specified in the |
… LaunchTemplateBlockDeviceMappingRequest)
ok, i've finally verified this works via manual integration testing. good to merge! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for this! 🚀
1. Issue, if available:
2. Description of changes:
3. How was this change tested?
make test
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.