Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor getting started guides #1193

Merged
merged 6 commits into from
Feb 25, 2022
Merged

Conversation

geoffcline
Copy link
Contributor

1. Issue, if available:
too many guides in left nav

2. Description of changes:
add new "getting started" nav section, with landing page

move guides under this new parent page

separate grafana out into own guide

3. How was this change tested?
netlify preview

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@geoffcline geoffcline added the documentation Improvements or additions to documentation label Jan 20, 2022
@geoffcline geoffcline self-assigned this Jan 20, 2022
@netlify
Copy link

netlify bot commented Jan 20, 2022

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: ec7b6a5

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/62195305ec25380007adbdb9

😎 Browse the preview: https://deploy-preview-1193--karpenter-docs-prod.netlify.app

mbevc1
mbevc1 previously approved these changes Jan 20, 2022
@geoffcline
Copy link
Contributor Author

revise

mbevc1
mbevc1 previously approved these changes Feb 2, 2022
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good to merge after the link is updated for the AWS getting started guide

@bwagner5
Copy link
Contributor

bwagner5 commented Feb 9, 2022

After rebase, we should be good!

@geoffcline geoffcline requested a review from bwagner5 February 25, 2022 21:23
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bwagner5 bwagner5 merged commit 6d5d976 into aws:main Feb 25, 2022
bwagner5 added a commit to bwagner5/karpenter that referenced this pull request Feb 28, 2022
bwagner5 added a commit that referenced this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants