Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed /tools/ in favor of direct go install to avoid version conflicts #1175

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

ellistarn
Copy link
Contributor

@ellistarn ellistarn commented Jan 18, 2022

1. Issue, if available:

2. Description of changes:
Tools previously could have dependency conflicts, even though they do not depend on each other. This directly installs package and managed versions inline to avoid possibility of conflicts.

3. How was this change tested?

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Jan 18, 2022

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: b5a830e

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61e748a1e0e191000861cb0f

@ellistarn ellistarn force-pushed the cosign branch 3 times, most recently from 2a3ee09 to 6da0c9c Compare January 18, 2022 23:03
@ellistarn ellistarn changed the title [Experimental] Upgraded ko, including SBOM into release process Removed /tools/ in favor of direct go install to avoid version conflicts Jan 18, 2022
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ellistarn ellistarn merged commit 8da4b40 into aws:main Jan 18, 2022
@ellistarn ellistarn deleted the cosign branch January 18, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants