Remove subnet and security group selector defaulting. #1151
Conversation
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: 4442579 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61e71755b729cf00075bc7db 😎 Browse the preview: https://deploy-preview-1151--karpenter-docs-prod.netlify.app |
ellistarn
force-pushed
the
defaults
branch
2 times, most recently
from
4a9786f to
503ef73
Compare
| @@ -236,6 +223,10 @@ spec: | |||
| resources: | |||
| cpu: 1000 | |||
| provider: | |||
| subnetSelector: | |||
There was a problem hiding this comment.
Now that we don't autodiscover, we should be telling customers how to choose a subnetSelector and a securityGroupSelector in our documentation. Maybe a line or two. Should we also call this out as required fields in our provider documentation?
We could use EKS as an example in our docs since this is AWS specific so should make sense to most customers. We could reference the clusterWorkerSG and cluster's subnets as good examples to select here
Also do we need to edit this para?
ellistarn
force-pushed
the
defaults
branch
3 times, most recently
from
88e5271 to
4a064e2
Compare
1. Issue, if available:
#1017
2. Description of changes:
Removed discovery via cluster name to avoid tag limitations for multi-cluster discovery. Instead, users must define their own discovery mechanisms for their use case. Moved cluster-based discovery to the getting started guide.
3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.