Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] only include capacity-type options for the capacity-type being requested #1115

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Jan 10, 2022

1. Issue, if available:
#1088

2. Description of changes:
Only include capacity-type options for the capacity-type being requested since Spot is not available in every region.

3. How was this change tested?
Tested provisioning OD and Spot nodes on a cluster

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Jan 10, 2022

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 3077b28

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61dc8e4b2b76670008285fbe

Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@bwagner5 bwagner5 merged commit 54c6b37 into aws:main Jan 10, 2022
@bwagner5 bwagner5 deleted the spot-options branch January 10, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants