Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix selector labels on helm chart #1092

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Jan 6, 2022

1. Issue, if available:
N/A

2. Description of changes:

  • Refactoring Helm labels #1001 added standard k8s labels across all resources and the ability for users to provide labels that are propagated to all resources. Part of that PR also updated the selectorLabels with these additional labels, however, selectorLabels are immutable so when upgrading the chart from the previous, those resources fail to Patch. This PR removes the additional selectors and sticks with the karpenter: controller and karpenter: webhook to maintain backwards compatibility.

3. How was this change tested?
tested in my local cluster by updating a previous installation with helm.

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Jan 6, 2022

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 894db9c

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61d75cf78871230007892c71

@felix-zhe-huang
Copy link
Contributor

Verified that the helm chart renders. LGTM

@bwagner5 bwagner5 merged commit d2ec0d7 into aws:main Jan 6, 2022
@bwagner5 bwagner5 deleted the fix-helm-selector-labels branch January 6, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants