-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating new Karpenter FAQ #1016
Conversation
❌ Deploy Preview for karpenter-docs-prod failed. 🔨 Explore the source changes: 5298e5b 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61e1e8515deb180008b84f42 |
/hold |
I added a bunch of questions to the FAQ, based on discussions with @rothgar . I put "NEEDS INFO" in a few places where I need some help. I cut some useful information from the section on Deprovisioning, but I plan to add content that is useful into the "Deprovisioning nodes" page. |
Hm. Many of these questions will be manager specific. E.g upgrades works differently on kOps and Karpenter. Any thoughts on how to show these nuances? |
website/content/en/docs/faq.md
Outdated
|
||
## Upgrading | ||
### How do I upgrade Karpenter? | ||
!!! NEEDS INFO !!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!!! NEEDS INFO !!! | |
Karpenter is a controller that runs in your cluster, but it is not tied to a specific Kubernetes version like the cluster autoscaler is. It is recommended you use existing upgrade mechanisms you have to upgrade your core add-ons in Kubernetes to keep Karpenter upgraded to stay up to date on bug fixes and new features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we provide an example? Do I re-apply the helm chart? Do I patch the deployment? Does it matter if I'm running the controller on EC2 or Fargate? Should I schedule during off-hours?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need more information here.
website/content/en/docs/faq.md
Outdated
|
||
* Set the [ALB target type]({{< ref "https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.3/guide/ingress/annotations/#target-type" >}}) to IP mode for the pods | ||
* Set [readiness gate]({{< ref "https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.3/deploy/pod_readiness_gate/" >}}) on the namespace. | ||
The default is round robin at node level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this depend on 1/ the TargetType and 2/ the traffic policy (cluster or local)?
@@ -0,0 +1,122 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing a lot of AWS Specific FAQs in here. Can we scope this to AWS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only 6 of the 27 questions explicitly call out AWS. I'm going to go through all the comments to get this doc in a sane state. Then we can talk through how we might change the scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the mean time, any time I find an FAQ question that is duplicated in the concepts section, I'll add a link to it from here. That should help reduce the amount of drift between the two docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've responded to all the comments I could at this point. If others agree, I'd like to have this merged and we can iterate on the published document.
@@ -0,0 +1,122 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only 6 of the 27 questions explicitly call out AWS. I'm going to go through all the comments to get this doc in a sane state. Then we can talk through how we might change the scope.
website/content/en/docs/faq.md
Outdated
|
||
## Upgrading | ||
### How do I upgrade Karpenter? | ||
!!! NEEDS INFO !!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need more information here.
@@ -0,0 +1,122 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the mean time, any time I find an FAQ question that is duplicated in the concepts section, I'll add a link to it from here. That should help reduce the amount of drift between the two docs.
I removed the question that was specific to the Kubernetes upgrades. |
1. Issue, if available:
2. Description of changes:
The first commit for this PR is the original Karpenter FAQ from the previous release that was dropped for v0.5. I'm starting with the old version so that you can see the changes I'm making going forward. This is a work in progress for now. Do not merge!
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.