Refactoring Helm labels #1001
Merged
Refactoring Helm labels #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Lamirault <[email protected]>
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: abca99f 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61d55f9c994b5300088cdf95 |
Signed-off-by: Nicolas Lamirault <[email protected]>
|
I've just canceled my PR with Deployment/Service labels, your work seems much more flexible 👍 |
bwagner5
reviewed
Dec 15, 2021
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
Signed-off-by: Nicolas Lamirault <[email protected]>
ellistarn
reviewed
Dec 15, 2021
ellistarn
reviewed
Dec 15, 2021
ellistarn
reviewed
Dec 15, 2021
Signed-off-by: Nicolas Lamirault <[email protected]>
bwagner5
reviewed
Jan 4, 2022
bwagner5
requested changes
Jan 4, 2022
Signed-off-by: Nicolas Lamirault <[email protected]>
This was referenced Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
2. Description of changes:
Refactoring Helm labels like in Helm documentation
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.