From 2d4b8477994640c28052a6a0942de688740c39b1 Mon Sep 17 00:00:00 2001 From: Brandon McNama <brandonmcnama@outlook.com> Date: Thu, 27 Jan 2022 20:35:13 +0000 Subject: [PATCH 1/3] Update Provisioner Docs Example The `spec.limits.resources.cpu` field should be a string, not an int. --- website/content/en/v0.5.6/provisioner.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/content/en/v0.5.6/provisioner.md b/website/content/en/v0.5.6/provisioner.md index b015bd96c65a..610edeb4dc4b 100644 --- a/website/content/en/v0.5.6/provisioner.md +++ b/website/content/en/v0.5.6/provisioner.md @@ -52,7 +52,7 @@ spec: # Limits prevent Karpenter from creating new instances once the limit is exceeded. limits: resources: - cpu: 1000 + cpu: "1000" memory: 1000Gi # These fields vary per cloud provider, see your cloud provider specific documentation From 581a360adc5afda2463a6a24b77e492f127f9317 Mon Sep 17 00:00:00 2001 From: Brandon McNama <brandonmcnama@outlook.com> Date: Mon, 31 Jan 2022 23:59:52 -0500 Subject: [PATCH 2/3] Update preview docs instead --- website/content/en/preview/provisioner.md | 4 ++-- website/content/en/v0.5.6/provisioner.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/website/content/en/preview/provisioner.md b/website/content/en/preview/provisioner.md index b015bd96c65a..f752b778bedc 100644 --- a/website/content/en/preview/provisioner.md +++ b/website/content/en/preview/provisioner.md @@ -52,7 +52,7 @@ spec: # Limits prevent Karpenter from creating new instances once the limit is exceeded. limits: resources: - cpu: 1000 + cpu: "1000" memory: 1000Gi # These fields vary per cloud provider, see your cloud provider specific documentation @@ -162,7 +162,7 @@ The provisioner spec includes a limits section (`spec.limits.resources`), which Presently, Karpenter supports `memory` and `cpu` limits. -CPU limits are described with a `DecimalSI` value, usually a natural integer. +CPU limits are described with a `DecimalSI` value, usually a natural integer. Note that the Kubernetes API will return a string value here, so when using e.g. ArgoCD, it's better to specify the CPU limit as a string. Memory limits are described with a [`BinarySI` value, such as 1000Gi.](https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#meaning-of-memory) diff --git a/website/content/en/v0.5.6/provisioner.md b/website/content/en/v0.5.6/provisioner.md index 610edeb4dc4b..b015bd96c65a 100644 --- a/website/content/en/v0.5.6/provisioner.md +++ b/website/content/en/v0.5.6/provisioner.md @@ -52,7 +52,7 @@ spec: # Limits prevent Karpenter from creating new instances once the limit is exceeded. limits: resources: - cpu: "1000" + cpu: 1000 memory: 1000Gi # These fields vary per cloud provider, see your cloud provider specific documentation From c7f79a83fc122f5eab9f5d63ac0f8595ee5f9dde Mon Sep 17 00:00:00 2001 From: Ellis Tarn <ellistarn@gmail.com> Date: Tue, 1 Feb 2022 14:26:23 -0800 Subject: [PATCH 3/3] Update website/content/en/preview/provisioner.md --- website/content/en/preview/provisioner.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/content/en/preview/provisioner.md b/website/content/en/preview/provisioner.md index f752b778bedc..c852febb2d48 100644 --- a/website/content/en/preview/provisioner.md +++ b/website/content/en/preview/provisioner.md @@ -162,7 +162,7 @@ The provisioner spec includes a limits section (`spec.limits.resources`), which Presently, Karpenter supports `memory` and `cpu` limits. -CPU limits are described with a `DecimalSI` value, usually a natural integer. Note that the Kubernetes API will return a string value here, so when using e.g. ArgoCD, it's better to specify the CPU limit as a string. +CPU limits are described with a `DecimalSI` value. Note that the Kubernetes API will coerce this into a string, so we recommend against using integers to avoid GitOps skew. Memory limits are described with a [`BinarySI` value, such as 1000Gi.](https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#meaning-of-memory)