Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit Resource Limits in Metrics Controller #840

Closed
suket22 opened this issue Nov 23, 2021 · 1 comment · Fixed by #1872
Closed

Emit Resource Limits in Metrics Controller #840

suket22 opened this issue Nov 23, 2021 · 1 comment · Fixed by #1872
Assignees
Labels
feature New feature or request

Comments

@suket22
Copy link
Contributor

suket22 commented Nov 23, 2021

Tell us about your request
Emit metrics for resource usage by the provisioner.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
There's a new counter controller that this PR introduces - #817
It sets the resources being consumed by the provisioner in the provisioner.status.Resources but we should also emit this and create a Grafana dashboard off those metrics.

Are you currently working around this issue?
N/A

Additional context
N/A

Attachments
If you think you might have additional information that you'd like to include via an attachment, please do - we'll take a look. (Remember to remove any personally-identifiable information.)

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@suket22 suket22 added the feature New feature or request label Nov 23, 2021
@rajakshay
Copy link

rajakshay commented Apr 20, 2022

Adding my use-case here: Im trying to achieve an equivalent of High ASG utilization monitor in Karpenter. This feature will be useful to get the percentage capacity in use, and proactively update the limits on a provisioner before pods get stuck in a Pending state forever.

@tzneal tzneal self-assigned this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants