Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for Configuration of Kubernetes Client-Side Throttling within Karpenter #722

Closed
bwagner5 opened this issue Oct 1, 2021 · 1 comment
Labels
documentation Improvements or additions to documentation feature New feature or request

Comments

@bwagner5
Copy link
Contributor

bwagner5 commented Oct 1, 2021

Tell us about your request
What do you want us to build?

Document the CLI configurations and how to configure the kubernetes client QPS and burst.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
What outcome are you trying to achieve, ultimately, and why is it hard/impossible to do right now? What is the impact of not having this problem solved? The more details you can provide, the better we'll be able to understand and solve the problem.

Depending on how large of a cluster karpenter is operating in and how large scale ups are (100's of nodes scaling up at once), the kubernetes client-side throttling will need to be adjusted. Karpenter performs a large number of binds when scaling up nodes, so we're currently setting the defaults higher than the client shipped defaults, but users may want to adjust further depending on their k8s apiserver settings.

Are you currently working around this issue?
How are you currently solving this problem?

N/A

Additional context
Anything else we should know?

Attachments
If you think you might have additional information that you'd like to include via an attachment, please do - we'll take a look. (Remember to remove any personally-identifiable information.)

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@bwagner5 bwagner5 added the feature New feature or request label Oct 1, 2021
@njtran njtran added the documentation Improvements or additions to documentation label Aug 8, 2022
@bwagner5
Copy link
Contributor Author

bwagner5 commented Nov 7, 2022

This isn't really needed anymore since we no longer bind pods.

@bwagner5 bwagner5 closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants