Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Controller retries based off the longest requeue, rather than shortest #663

Closed
njtran opened this issue Sep 8, 2021 · 0 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@njtran
Copy link
Contributor

njtran commented Sep 8, 2021

Version

Karpenter: Latest

Kubernetes: v1.20.0

The Node controller reconciles nodes for emptiness, expiration, finalizers, liveness, and readiness purposes to help reconcile states of nodes provisioned by Karpenter.

Expected Behavior

We expect that the next time we reconcile a node, we would go through the reconcile loop the next time one of the above 5 processes need to happen.

Actual Behavior

We end up requeuing a reconcile for the largest duration desired, instead of smallest.

Steps to Reproduce the Problem

With provisioner fields ttlSecondsAfterEmpty and ttlSecondsUntilExpired set, where empty is set to something like 30s, and expired is set to something like 80000, we will end up re-reconciling not in 30s.

@njtran njtran added the bug Something isn't working label Sep 8, 2021
@njtran njtran self-assigned this Sep 8, 2021
@njtran njtran closed this as completed Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant