Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm - Add NodePool and EC2NodeClass #5135

Closed
mtavaresmedeiros opened this issue Nov 21, 2023 · 3 comments
Closed

Helm - Add NodePool and EC2NodeClass #5135

mtavaresmedeiros opened this issue Nov 21, 2023 · 3 comments
Labels
feature New feature or request

Comments

@mtavaresmedeiros
Copy link

Description

What problem are you trying to solve?
Allow specifying NodePool and Ec2NodeClass
How important is this feature to you?
It will simplify the installation of the karpenter with helm, allowing specifying a node pool and ec2nodeclass in the initial installation.

Ex: Install the karpenter with the terraform in a Kubernetes cluster with fargate(serverless) or another option with 0 nodes, and install the GitOps tools after it, without the need to create another resource (NodePool and Ec2NodeClass), and has all things work out-of-the-box.

If it is fine, I can do the PR.

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@mtavaresmedeiros mtavaresmedeiros added feature New feature or request needs-triage Issues that need to be triaged labels Nov 21, 2023
@jonathan-innis
Copy link
Contributor

We had a similar request here: #1956. We are generally recommending that users build a "top-level chart" that take this chart as a dependency elsewhere since we are generally trying to avoid the burden of having to maintain the chart ourselves. given the number of options that we would have to support.

@jonathan-innis jonathan-innis removed the needs-triage Issues that need to be triaged label Nov 21, 2023
@mtavaresmedeiros
Copy link
Author

hum... #1956 (comment), this commentary really makes sense. closing.

@younsl
Copy link

younsl commented Sep 16, 2024

@mtavaresmedeiros In my production cluster, I am using my own karpenter-nodepool chart, integrated into the karpenter chart as a child chart.

Subchart dependencies declared in the Chart.yaml of the karpenter chart:

# charts/karpenter/Chart.yaml
dependencies:
  - name: karpenter-nodepool
    version: 0.0.7
    repository: "file://./charts/karpenter-nodepool"
    condition: karpenter-nodepool.enabled

Directory structure for karpenter chart, including karpenter-nodepool chart as subchart:

karpenter  # parent chart
├── Chart.lock
├── Chart.yaml
├── README.md
├── charts
│   └── karpenter-nodepool  # subchart
├── crds
├── templates
└── values.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants