Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten IAM permissions around deletion #4159

Closed
johngmyers opened this issue Jun 28, 2023 · 2 comments
Closed

Tighten IAM permissions around deletion #4159

johngmyers opened this issue Jun 28, 2023 · 2 comments
Labels
question Further information is requested

Comments

@johngmyers
Copy link

Description

What problem are you trying to solve?

Reduce the scope of Karpenter's IAM permissions to the minimum needed.

The example IAM permissions for KarpenterControllerPolicy grant Karpenter to terminate any instance and delete any launch template in the account.

These permissions should have conditions limiting them to instances and launch templates that are tagged by Karpenter as belonging to the cluster.

How important is this feature to you?

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@johngmyers johngmyers added the feature New feature or request label Jun 28, 2023
@jonathan-innis
Copy link
Contributor

These permissions should have conditions limiting them to instances and launch templates that are tagged by Karpenter as belonging to the cluster.

This template was recently updated to scope these permissions more like you suggest.

@jonathan-innis jonathan-innis added question Further information is requested and removed feature New feature or request labels Jun 29, 2023
@jonathan-innis
Copy link
Contributor

Closing this since the new CF template now only allows Karpenter to delete instances that contain these set of tag keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants