From f8b0c3648cd429f1634a3c186a0c565b0f02b015 Mon Sep 17 00:00:00 2001 From: Cameron Senese <36317955+cameronsenese@users.noreply.github.com> Date: Thu, 17 Dec 2020 10:06:20 +1100 Subject: [PATCH] Fix errors in hack/quick-install.sh (#185) Fix issues: 1/ Command helm upgrade --install karpenter charts/karpenter fails. 2/ Uninstall: Current order of operation leaves deployment: karpenter and statefulset: prometheus-karpenter-monitor remaining: --- hack/quick-install.sh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hack/quick-install.sh b/hack/quick-install.sh index def2e38d2bf7..2e35c7dda45f 100755 --- a/hack/quick-install.sh +++ b/hack/quick-install.sh @@ -4,15 +4,17 @@ set -eu -o pipefail main() { local command=${1:-'--apply'} if [[ $command = "--apply" ]]; then + echo "Installing Karpenter & dependencies.." apply echo "Installation complete!" elif [[ $command = "--delete" ]]; then + echo "Uninstalling Karpenter & dependencies.." delete echo "Uninstallation complete!" else echo "Error: invalid argument: $command" >&2 usage - exit 22 # EINVAL + exit 22 # EINVAL fi } @@ -27,9 +29,9 @@ EOF } delete() { + helm delete karpenter || true helm delete cert-manager --namespace cert-manager || true helm delete kube-prometheus-stack --namespace monitoring || true - helm delete karpenter || true kubectl delete namespace cert-manager monitoring || true } @@ -67,7 +69,7 @@ apply() { --set nodeExporter.enabled=false \ --set prometheus.enabled=false - helm upgrade --install karpenter charts/karpenter + helm upgrade --install karpenter karpenter/karpenter } usage