Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Added cluster.Consolidated() checks to test #190

Merged
merged 1 commit into from
Jan 31, 2023
Merged

test: Added cluster.Consolidated() checks to test #190

merged 1 commit into from
Jan 31, 2023

Conversation

ellistarn
Copy link
Contributor

@ellistarn ellistarn commented Jan 31, 2023 •
edited
Loading

Fixes #

Description

How was this change tested?

Tests to catch this bug: #179 (comment)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ellistarn ellistarn requested a review from a team as a code owner January 31, 2023 22:28
@ellistarn ellistarn requested a review from spring1843 January 31, 2023 22:28
jonathan-innis
jonathan-innis approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ellistarn ellistarn enabled auto-merge (squash) January 31, 2023 22:29
@coveralls
Copy link

coveralls commented Jan 31, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4058921171

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 79.61%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/deprovisioning/controller.go 2 77.16%
pkg/scheduling/requirements.go 2 98.5%
Totals Coverage Status
Change from base Build 4058902271: -0.02%
Covered Lines: 6372
Relevant Lines: 8004
💛 - Coveralls

@ellistarn ellistarn merged commit 5ba2190 into kubernetes-sigs:main Jan 31, 2023
@ellistarn ellistarn deleted the te branch February 2, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@spring1843 spring1843 Awaiting requested review from spring1843 spring1843 was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ellistarn @coveralls @jonathan-innis