Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for ImageGCHighThresholdPercent and ImageGCLowThresholdPercent #172

Merged
merged 8 commits into from
Jan 26, 2023
Merged

support for ImageGCHighThresholdPercent and ImageGCLowThresholdPercent #172

merged 8 commits into from
Jan 26, 2023

Conversation

lucass4
Copy link
Contributor

@lucass4 lucass4 commented Jan 23, 2023 •
edited
Loading

Fixes aws/karpenter-provider-aws#3110

Description

Add support for ImageGCHighThresholdPercent and ImageGCLowThresholdPercent.
I am submitting this one first to ensure the contract is correct before implementing it in the main karpenter project.

How was this change tested?

Tested using unit tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lucass4 lucass4 requested a review from a team as a code owner January 23, 2023 22:09
@lucass4 lucass4 requested a review from bwagner5 January 23, 2023 22:09
@ellistarn
Copy link
Contributor

Thanks for the contribution! A few suggestions.

@coveralls
Copy link

coveralls commented Jan 24, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4011559987

  • 14 of 22 (63.64%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 77.821%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1alpha5/zz_generated.deepcopy.go 2 10 20.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/provisioner.go 2 85.56%
pkg/controllers/provisioning/batcher.go 3 70.0%
Totals Coverage Status
Change from base Build 4008633660: -0.01%
Covered Lines: 6070
Relevant Lines: 7800
💛 - Coveralls

ellistarn
ellistarn previously approved these changes Jan 24, 2023
View reviewed changes
@lucass4
Copy link
Contributor Author

lucass4 commented Jan 24, 2023

Linking to the karppenter change: aws/karpenter-provider-aws#3264

@lucass4 lucass4 mentioned this pull request Jan 24, 2023
Merged
jonathan-innis
jonathan-innis reviewed Jan 25, 2023
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Just a couple comments.

@ellistarn ellistarn enabled auto-merge (squash) January 26, 2023 02:16
@lucass4 lucass4 requested review from jonathan-innis and removed request for bwagner5 January 26, 2023 02:18
@ellistarn ellistarn merged commit 8e8c049 into kubernetes-sigs:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn ellistarn approved these changes

@jonathan-innis jonathan-innis Awaiting requested review from jonathan-innis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add imageGCThresholdPercent support to kubeletConfiguration
4 participants
@lucass4 @ellistarn @coveralls @jonathan-innis