feat(java): use immutable java implementations of JSII primitive collection types array and map #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection types array and map
bmaizels
approved these changes
Sep 5, 2019
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit wraps JSII primitive collections with immutable Java implementations. This includes wrapping arrays with Collections.unmodifiableList() and maps with Collections.unmodifiableMap(). This helps keep Java collections in sync with Node.
It also includes a refactor to the Java code generator around the generation of builders for objects.
Finally, it fixes a bug in the testing framework (negatives.test.ts) that was checking a value was not null rather than defined. This missed the case of the tests returning undefined.
Fixes #722
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.