fix(jsii-diff): handle recursive types #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Structural type checking would recurse endlessly if a struct had a member with the same type as itself, or the same type as a struct that contained itself. Add a cache to prevent infinite recursion. Also in this commit: `tryFindFqn` no longer explodes if the referenced assembly couldn't be found, but simply returns `undefined` as it should.
ghost
requested a review
from 
RomainMuller
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Structural type checking would recurse endlessly if a struct had a
member with the same type as itself, or the same type as a struct that
contained itself.
Add a cache to prevent infinite recursion.
Also in this commit:
tryFindFqnno longer explodes if the referencedassembly couldn't be found, but simply returns
undefinedas it should.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.