fix(java): Stop using Streams to render params #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Java cod egenerated by `jsii-pacmak` used to use `Stream` concatenations to render parameters into an `Object` array when passing to the low-level `jsii` engine. In the majority of cases this worked fine, however in casesw where the last argument was an `enum`, this caused `javac` type inferrence to impose bounds on the `Stream`'s item type that could not be met by non-`enum` types. Additionally, as this code demonstrates, the `Stream`-based code was unnecessarily complicated as it is possible to initialize an array literal in place, by using less code, which also reads simpler, and incurs less memory churn. It's a win all over the board 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java cod generated by
jsii-pacmakused to useStreamconcatenations to render parameters into an
Objectarray when passingto the low-level
jsiiengine. In the majority of cases this workedfine, however in cases where the last argument was an
enum, thiscaused
javactype inferrence to impose bounds on theStream's itemtype that could not be met by non-
enumtypes.Additionally, as this code demonstrates, the
Stream-based code wasunnecessarily complicated as it is possible to initialize an array
literal in place, by using less code, which also reads simpler, and
incurs less memory churn. It's a win all over the board 🎉
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.