-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jsii-pacmak): handles 'default' doc component for go #4115
Conversation
@RomainMuller hopefully a quick fix here |
Pull request has been modified.
@RomainMuller had some test failures due mistakes with manually updating snapshot file. I discovered this is built into the tooling and updated the snapshot that way. Can you approve the workflows to run when you get a chance. |
Pull request has been modified.
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Merging (with squash)... |
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
Pull request has been modified.
The default values were being parsed but not emitted for Go, effectively deleting them from the generated Go code. This was already handled for other languages.
note: following the pattern seen for link, I added the extra call to
this.emitComment();
resolves: 3885
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.