fix(python): Lift the entire data class hierarchy #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstufft
force-pushed
the
keyword-lifting-fix
branch
from
8495e08 to
81f35ac
Compare
RomainMuller
changed the title
garnaat
approved these changes
Mar 28, 2019
eladb
approved these changes
Mar 28, 2019
| stack.push(...current.interfaces.map(ifc => resolver.dereference(ifc) as spec.InterfaceType)); | ||
| } | ||
|
|
||
| // Add all of the properties of this interface to our list of properties. |
There was a problem hiding this comment.
Recursion always reads easier to me, but that's just preference
RomainMuller
added a commit
that referenced
this pull request
Mar 28, 2019
### Bug Fixes * **kernel:** Transitively consider properties when deserializing structs ([#409](#409)) ([66789e8](66789e8)) * **python:** Lift the entire data class hierarchy ([#408](#408)) ([f813620](f813620)) ### Features * **python:** Add support for synchronous callbacks ([#407](#407)) ([4cb91b3](4cb91b3))
Merged
eladb
pushed a commit
that referenced
this pull request
Mar 28, 2019
### Bug Fixes * **kernel:** Transitively consider properties when deserializing structs ([#409](#409)) ([66789e8](66789e8)) * **python:** Lift the entire data class hierarchy ([#408](#408)) ([f813620](f813620)) ### Features * **python:** Add support for synchronous callbacks ([#407](#407)) ([4cb91b3](4cb91b3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They Python code generation was only lifting the properties of the specified data class, but it wasn't lifting the properties of all of the data classes in the inheritance tree.
We have to do that, so we'll go ahead and walk our entire interface hierarchy and build up a flat list of all of the properties, and use that list to generate our lifted properties.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.