fix(rosetta): attempts transliteraiton to unsupported languages #3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rosetta attempted to perform transliteration to unsupported languages when requested to, which would likely result in incorrect output, if not a complete crash (due to missing required configuration). This stops trying to emit transliterated assemblies for languages that the original assembly does not support.
| @@ -99,6 +100,12 @@ export async function transliterateAssembly( | |||
| const now = new Date().getTime(); | |||
| // eslint-disable-next-line no-await-in-loop | |||
| const result = await loadAssembly(); | |||
|
|
|||
| if (result.targets?.[targetName(language)] == null) { | |||
| // This language is not supported by the assembly, so we skip it... | |||
There was a problem hiding this comment.
Wondering if we need some explicit output to tell callers that a language is unsupported?
There was a problem hiding this comment.
Yeah but we'd want that ONLY if the language was specifically requested...?
MrArnoldPalmer
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rosetta attempted to perform transliteration to unsupported languages
when requested to, which would likely result in incorrect output, if not
a complete crash (due to missing required configuration).
This stops trying to emit transliterated assemblies for languages that
the original assembly does not support.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.