Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose unknownSnippets config #3475

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Conversation

MrArnoldPalmer
Copy link
Contributor

Exposes the unknownSnippets configuration option on
transliterateAssembly to allow callers to choose how to handle
snippets missing from the tablet file.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Exposes the `unknownSnippets` configuration option on
`transliterateAssembly` to allow callers to choose how to handle
snippets missing from the tablet file.
@MrArnoldPalmer MrArnoldPalmer requested a review from a team April 6, 2022 19:42
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 6, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2022

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Apr 6, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2022

Merging (with squash)...

@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2022

Merging (with squash)...

@RomainMuller RomainMuller merged commit e9d99a0 into main Apr 7, 2022
@RomainMuller RomainMuller deleted the feat/rosetta-ignore-missing branch April 7, 2022 09:14
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants