fix(jsii): excessive overrides declarations registered #3375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Members inherited from parent base classes, which also implemented a locally implemented interface member, would get tagged with the `overrides` marker for the interface, which was incorrect, since the declaring type did not implement the interface directly. This is solved by passing the inherited members by-copy to the validator, so side effects of it aren't visible to the final assembly.
rix0rrr
approved these changes
Feb 9, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Members inherited from parent base classes, which also implemented a
locally implemented interface member, would get tagged with the
overridesmarker for the interface, which was incorrect, since thedeclaring type did not implement the interface directly.
This is solved by passing the inherited members by-copy to the
validator, so side effects of it aren't visible to the final assembly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.