-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(go): Use type registry to find the correct target type for JSII Proxy #3354
Conversation
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice - thank you!
I only have a very minor comment here, and we're ready to ship.
packages/@jsii/go-runtime/jsii-runtime-go/internal/kernel/conversions.go
Show resolved
Hide resolved
@all-contributors add @arnogeurts-sqills for bug, code |
I've put up a pull request to add @arnogeurts-sqills! 🎉 |
…ersions.go Co-authored-by: Romain Marcadier <[email protected]>
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
@RomainMuller do you need/expect anything else from me regarding this PR, or can it be merged? |
It'll be merged! I had actually hoped automation would merge it overnight! |
With this PR, the type that is instantiated as JSII Proxy is looked up from the type registry using the TypeFQDN in the ref. If that type is registered in the type registry AND that type is assignable to the targeted value type, than that type is used to instantiate the JSII proxy.
Fixes #3353 and relates to #2819.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.