-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rosetta): Rosetta manages dependencies automatically #3269
Conversation
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
@@ -7,7 +7,7 @@ export async function checkCoverage(assemblyLocations: readonly string[]): Promi | |||
logging.info(`Loading ${assemblyLocations.length} assemblies`); | |||
const assemblies = await loadAssemblies(assemblyLocations, false); | |||
|
|||
const snippets = Array.from(allTypeScriptSnippets(assemblies, true)); | |||
const snippets = Array.from(await allTypeScriptSnippets(assemblies, true)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allTypeScriptSnippets
returns a promise to an array already...
const snippets = Array.from(await allTypeScriptSnippets(assemblies, true)); | |
const snippets = await allTypeScriptSnippets(assemblies, true); |
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Merging (with squash)... |
Merging (with squash)... |
It's quite an annoying bother and pretty brittle to have to set up a full dependency directory to compile examples in.
In CDK, we use the directory of the
decdk
package to do this, because we have external knowledge that all packageswill be symlinked into this directory.
That mechanism is brittle and revolves around having outside knowledge. Instead, make Rosetta manage the dependency closure itself, when user declare
exampleDependencies
inpackage.json
:It is not necessary to redeclare any of the
dependencies
andpeerDependencies
already inpackage.json
: those are automatically included.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.