Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rosetta): expose the 'extract' API #3161

Merged
merged 11 commits into from
Nov 12, 2021
Merged

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Nov 11, 2021

Expose parts of the extract API (cache reading and mass translating)
to consumers, so that downstream tools can build example manipulators
as well.

  • The original exposed Rosetta class is renamed to RosettaTabletReader, and is intended to be used by pacmak (or tools that primarily read tablets).
  • A new class is introduced, RosettaTranslator, which is intended to be used by tools that need to do mass translation. This new API exposes the worker-based caching and translateAll functionality.
  • The extract command is rewritten to use RosettaTranslator
  • The translateAll features are moved from extract.ts and extract_worker.ts to translate_all.ts and translate_all_worker.ts.
  • Add a function to build a snippet from source with /// !show|!hide directives, make it clear when each is supposed to be used.
  • Fix the console.error() suppression from the TypeScript compiler that was using an incorrect substring.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rix0rrr rix0rrr requested a review from a team November 11, 2021 19:36
@rix0rrr rix0rrr self-assigned this Nov 11, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 11, 2021
@rix0rrr rix0rrr force-pushed the huijbers/expose-extract-api branch from c0c23fa to 584f3e1 Compare November 12, 2021 10:20
@rix0rrr rix0rrr requested a review from njlynch November 12, 2021 13:56
@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Nov 12, 2021
@mergify mergify bot merged commit c3b30c0 into main Nov 12, 2021
@mergify mergify bot deleted the huijbers/expose-extract-api branch November 12, 2021 14:32
@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2021

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants