-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rosetta): expose the 'extract' API #3161
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0c23fa
to
584f3e1
Compare
njlynch
suggested changes
Nov 12, 2021
… into huijbers/expose-extract-api
njlynch
approved these changes
Nov 12, 2021
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose parts of the
extract
API (cache reading and mass translating)to consumers, so that downstream tools can build example manipulators
as well.
Rosetta
class is renamed toRosettaTabletReader
, and is intended to be used bypacmak
(or tools that primarily read tablets).RosettaTranslator
, which is intended to be used by tools that need to do mass translation. This new API exposes the worker-based caching andtranslateAll
functionality.extract
command is rewritten to useRosettaTranslator
translateAll
features are moved fromextract.ts
andextract_worker.ts
totranslate_all.ts
andtranslate_all_worker.ts
./// !show|!hide
directives, make it clear when each is supposed to be used.console.error()
suppression from the TypeScript compiler that was using an incorrect substring.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.