fix(go): panic on callback: using *<interface> as <interface> #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainMuller
added
language/go
RomainMuller
force-pushed
the
rmuller/fix-aspects
branch
from
a876460 to
d0dd009
Compare
RomainMuller
force-pushed
the
rmuller/fix-aspects
branch
from
d0dd009 to
51cde72
Compare
The callback handling logic was incorrectly handling "pure" interface parameters. The reflection piece would create a new argument value in preparation for the callback, however for interfaces, it would leave the pointer to the interface type (as returned by `reflect.New`) instead of indirecting to the interface itself as appropriate. Fixes #2793
RomainMuller
force-pushed
the
rmuller/fix-aspects
branch
from
51cde72 to
0908f4c
Compare
MrArnoldPalmer
approved these changes
Apr 20, 2021
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback handling logic was incorrectly handling "pure" interface
parameters. The reflection piece would create a new argument value in
preparation for the callback, however for interfaces, it would leave the
pointer to the interface type (as returned by
reflect.New) instead ofindirecting to the interface itself as appropriate.
Fixes #2793
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.