feat(superchain): install both Node 10 and Node 14 #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to switch to Node 14 for CDK v2, and so we need Node 14 be present in the Superchain image. At the same time, we want to continue testing v1 against Node 10, so we ALSO need Node 10 present in the image. Use NVM to install both versions in parallel and providing a command to switch between the two. Node 10 is the default, build scripts can switch to Node14 by doing either: ``` $ nvm use 14 $ nvm exec 14 <command> ```
RomainMuller
approved these changes
Mar 17, 2021
rix0rrr
added
pr/do-not-merge
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
Closed
5 tasks
This was referenced Mar 23, 2021
RomainMuller
added a commit
that referenced
this pull request
Mar 23, 2021
Includes the following: - Revert "fix(superchain): use entrypoint to set up nvm (#2736)" - This reverts commit 0e247b6. - Revert "feat(superchain): `$NVM_USE_VERSION` selects Node.js version (#2726)" - This reverts commit fb9abf9. - Revert "feat(superchain): install both Node 10 and Node 14 (#2718)" - This reverts commit 3ca97d9.
RomainMuller
added a commit
that referenced
this pull request
Mar 23, 2021
…2737) Includes the following: - Revert "fix(superchain): use entrypoint to set up nvm (#2736)" - This reverts commit 0e247b6. - Revert "feat(superchain): `$NVM_USE_VERSION` selects Node.js version (#2726)" - This reverts commit fb9abf9. - Revert "feat(superchain): install both Node 10 and Node 14 (#2718)" - This reverts commit 3ca97d9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to switch to Node 14 for CDK v2, and so we need Node 14 be
present in the Superchain image.
At the same time, we want to continue testing v1 against Node 10, so
we ALSO need Node 10 present in the image.
Use NVM to install both versions in parallel and providing a command
to switch between the two.
Node 10 is the default, build scripts can switch to Node14 by doing
either:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.