Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pacmak): Python submodules don't have docstrings #2681

Merged
merged 3 commits into from
Mar 16, 2021

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Mar 12, 2021

Propagate submodule docs to Python docstrings.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Propagate submodule docs to Python docstrings.
@rix0rrr rix0rrr self-assigned this Mar 12, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 12, 2021
@rix0rrr rix0rrr changed the title fix(jsii-pacmak): Python submodules don't have docstrings fix(pacmak): Python submodules don't have docstrings Mar 12, 2021
Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relatively straightforward 👍🏻

@rix0rrr rix0rrr removed the request for review from RomainMuller March 16, 2021 14:13
@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Mar 16, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2021

Merging (with squash)...

@mergify mergify bot merged commit a950282 into main Mar 16, 2021
@mergify mergify bot deleted the huijbers/pacmak-python-submodule-docs branch March 16, 2021 16:12
@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2021

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants