fix(pacmak): go local replace do not respect --outdir in some cases
#2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We first look for the local module under `<outdir>` and only then the default `dist` directory of the dependency but since we don't break the search after we found it, the dist will override the outdir location. Adds a `break` from the inner loop if we found a replacement.
RomainMuller
approved these changes
Feb 16, 2021
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Merging (with squash)... |
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We first look for the local module under
<outdir>and only then the defaultdistdirectory of the dependency but since we don't break the search after we found it, the dist will override the outdir location.Adds a
breakfrom the inner loop if we found a replacement.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.