fix(java): JsiiRuntime.ErrorStreamSink does not respond to being interrupted #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrupted When the thread is interrupted, it should understand the VM is asking it to shut down, and stop polling the child process' STDERR for more data. Previously, the thread did not check Thread.interrupted(), and hence was ignoring requests to terminate, resulting in ugly errors during clean-up. This adds the necessary check for interrupt status, and stops the error sink as asked by the VM. Fixes #2533
RomainMuller
added
effort/small
eladb
approved these changes
Feb 24, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
zt-execto launch thejsii-runtimeprocess, as it offers better semanticsfor IO redirection than Java's standard
ProcessBuilderAPI (that it wraps). Thisincludes ways to pipe the standard outputs (in particular,
STDERR) though aline handler, which is exactly what we need to achieve in this particular case.
Since we no longer manage an error stream sink thread, we can hope that this
solves the issue of the thread not responding to interruptions correctly.
Fixes #2533
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.