fix(go): major version suffix is missing in module names for >=v2 #2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the [go modules spec], starting from 2.0.0, module names must include A “major version suffix” (e.g. `/v2`). [go modules spec]: https://golang.org/ref/mod#major-version-suffixes Fixes #2506
RomainMuller
reviewed
Feb 2, 2021
RomainMuller
approved these changes
Feb 2, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
pushed a commit
that referenced
this pull request
Feb 3, 2021
The major version suffix introduced in #2507 was added at the end of the full module name, but for submodules, the suffix is needed only after the root package name. Additionally, the `_init_` import failed to include the major version suffix as well. In order to cover these cases in tests, change the version of `jsii-calc` to `3.20.1` so that it will be a MV larger then 2.0. Fixes #2507
eladb
pushed a commit
that referenced
this pull request
Feb 3, 2021
…2519) The major version suffix introduced in #2507 was added at the end of the full module name, but for submodules, the suffix is needed only after the root package name. Additionally, the `_init_` import failed to include the major version suffix as well. In order to cover these cases in tests, change the version of `jsii-calc` to `3.20.120` and `@scope/jsii-calc-base-of-base` to `2.1.1` so that it will be a MV larger then 2.0 and we can verify this works both from top-level modules, submodules and transitive local dependencies. Fixes #2507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the go modules spec, starting from 2.0.0, module names must include
A “major version suffix” (e.g.
/v2).Fixes #2506
This commit also fixes #2509 by deleting the
local.go.sumfile from the output.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.