Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: submodules expose readmes and targets via jsii-reflect #2482

Merged
merged 7 commits into from
Jan 27, 2021

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 26, 2021

For the documentation for monocdk/v2, individual submodules need to be
able to have READMEs attached to them, as well as the targets
configuration of submodules needs to be exposed so that we can use this
to determine the FQNs of types in other languages (Java/C#/...).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…flect`

For the documentation for monocdk/v2, individual submodules need to be
able to have `README`s attached to them, as well as the `targets`
configuration of submodules needs to be exposed so that we can use this
to determine the FQNs of types in other languages (Java/C#/...).
@rix0rrr rix0rrr requested a review from RomainMuller January 26, 2021 13:28
@rix0rrr rix0rrr self-assigned this Jan 26, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 26, 2021
@@ -0,0 +1,4 @@
Read you, read me
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some real Lionel Richie energy right there

@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Jan 27, 2021
@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2021

Merging (with squash)...

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-5lHf64IXfvmr
  • Commit ID: 9c683f9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 33f41eb into main Jan 27, 2021
@mergify mergify bot deleted the huijbers/jsii-submodule-enhancements2 branch January 27, 2021 14:20
@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2021

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants