-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(go): runtime release tagging #2417
Conversation
Adds github actions workflows for automatically tagging jsii-runtime-go when jsii release branch is updated. This essentially publishes new runtime version. This may eventually be served better in delivlib but is much simpler in github actions for the alpha phase.
…tagging feat(go): runtime release tagging
…tagging separate repo dirs in action
…-runtime-release-tagging
…-runtime-release-tagging
.github/workflows/main.yml
Outdated
- uses: actions/cache@v2 | ||
with: | ||
path: '**/node_modules' | ||
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cache is... okay, but it's not doing as much work as it could... You'd probably benefit from also caching Yarn's cache, like the other jobs do.
Also - not sure how this deals with symlinks... I'd be tempted to be somewhat afraid it caches the referents of the symlinks to packages within the monorepo... Could this have consequences?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lemme know if this is more what you were thinking. Since this only needs yarn deps tried to exclude all the other languages package caches.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Merging (with squash)... |
Adds github actions workflows for automatically tagging jsii-runtime-go
when jsii release branch is updated. This essentially publishes new
runtime version. This may eventually be served better in delivlib but is
much simpler in github actions for the alpha phase.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.