fix(python): generate type-checking code #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomainMuller
added
bug
There were a number of issues with the generated code that caused it not to properly validate though `mypy`: - Properties and method names could collide with buit-in types - `mypy` is unable to check decorations on decorated declarations - Those must be opted out with `#types: ignore` - `mypy` is unable to check dynamic base classes - Those must be opted out with `#types: ignore` - Impossible protocol conformance through meta-class - Removed `JSClass` and `Referenceable` in favor of `Type` and `Any` - Incorrect inference for the `_values` dictionary in *structs* - Had to add proper type annotation there - Had to add some `assert foo is not Null` in the implementation of non-optional struct property getters, to satisfy type checking Those issues were highlighted in awslabs/cdk8s#194
RomainMuller
force-pushed
the
rmuller/python-typing
branch
from
8983d7c to
46b448c
Compare
eladb
approved these changes
Aug 16, 2020
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a number of issues with the generated code that caused it not
to properly validate though
mypy:mypyis unable to check decorations on decorated declarations#types: ignoremypyis unable to check dynamic base classes#types: ignoreJSClassandReferenceablein favor ofTypeandAny_valuesdictionary in structsassert foo is not Nullin the implementation ofnon-optional struct property getters, to satisfy type checking
Those issues were highlighted in awslabs/cdk8s#194
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.