fix(kernel): tarball unpacking does not behave like 'npm install' #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In it's wisdom, `npm install` does override the process' `umask` to `0o022` before unpackging the tarball, to ensure the produced install has the kind of permissions that one would expect, regardless of the system-configured `umask`. Because `@jsii/kernel` did not reproduce this behavior, loaded libraries could be unpacked with unexpectedly tight permissions, leading to weird issues when those files were used in contexts that required those permissions. For example, this is the cause of aws/aws-cdk#8233. Fixes #1765
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
suggested changes
Jun 30, 2020
| const originalUmask = process.umask(0o022); | ||
| try { | ||
| // untar the archive to its final location | ||
| tar.extract({ |
There was a problem hiding this comment.
You should use the built-in support in the tar library.
One of these options should help:
portableOmit metadata that is system-specific: ctime, atime, uid, gid, uname, gname, dev, ino, and nlink. Note that mtime is still included, because this is necessary for other time-based operations. Additionally, mode is set to a "reasonable default" for most unix systems, based on a umask value of 0o22.modeThe mode to set on the created file archive
There was a problem hiding this comment.
I feel portable is the right one to use here.
There was a problem hiding this comment.
Those options are specific to the create operation and this is the extract operation.
The only "built-in" option available is the umask option to tar.extract, however that is "internal" (and not exposed in the d.ts which is why I decided against using that).
eladb
approved these changes
Jul 1, 2020
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In it's wisdom,
npm installdoes override the process'umaskto0o022before unpackging the tarball, to ensure the produced installhas the kind of permissions that one would expect, regardless of the
system-configured
umask.Because
@jsii/kerneldid not reproduce this behavior, loaded librariescould be unpacked with unexpectedly tight permissions, leading to weird
issues when those files were used in contexts that required those
permissions. For example, this is the cause of aws/aws-cdk#8233.
Fixes #1765
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.