fix(dotnet): "Could not infer JSII type for .NET type 'AnonymousObject'" #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When obtained through an untyped way (e.g: as part of an opaque object for example), instances of `AnonymousObject` could not be cast back to their Kernel form, because the converter lacked a code path to handle this type. Instead, it insisted on trying to infer a "better" run-time type for it. This adds the necessary code path to handle this condition and properly return the reverse conversion. Fixes aws/aws-cdk#7977
RomainMuller
force-pushed
the
rmuller/fix-dotnet-anonymousobject
branch
from
c4552a9 to
3567bab
Compare
MrArnoldPalmer
approved these changes
Jul 27, 2020
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When obtained through an untyped way (e.g: as part of an opaque object
for example), instances of
AnonymousObjectcould not be cast back totheir Kernel form, because the converter lacked a code path to handle
this type. Instead, it insisted on trying to infer a "better" run-time
type for it.
This adds the necessary code path to handle this condition and properly
return the reverse conversion.
Fixes aws/aws-cdk#7977
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.