feat(pacmak/java): isolate maven repositories #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When preparing a Java package using Maven, `jsii-pacmak` now configures a dedicated `localRepository` for it's own use. This prevents artifacts cached from previous builds as well as local build artifacts to possibly interfere with the compilation process. This has the side-effect to force a re-download of all dependencies on each build (except those that are generated as part of the same build), which results in a performance degradation. It should be possible to make the local repository location user-configurable so this impact can be mitigated on a case-by-case basis.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
reviewed
Jun 2, 2020
| @@ -1,3 +1,4 @@ | |||
| .m2 | |||
There was a problem hiding this comment.
Why oh why not in a tempdir somewhere?
There was a problem hiding this comment.
Because local iterations will be much faster for not re-downloading things every single time. You can nuke this directory when you need it...
Additionally, I don't like dropping temporary directories somewhere where I will not be able to clean them up. I consider this is loitering.
MrArnoldPalmer
approved these changes
Jun 2, 2020
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When preparing a Java package using Maven,
jsii-pacmaknow configuresa dedicated
localRepositoryfor its own use. This prevents artifactscached from previous builds as well as local build artifacts to possibly
interfere with the compilation process.
This has the side-effect to force a re-download of all dependencies on
each build (except those that are generated as part of the same build),
which results in a performance degradation. It should be possible to
make the local repository location user-configurable so this impact can
be mitigated on a case-by-case basis.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.