fix(jsii-pacmak): invalid dotnet version suffixes #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes version suffix from version ranges in `.csproj` files generated by jsii-pacmak. Dotnet doesn't allow version suffixes that start with a number. Version ranges by default don't include prereleases so the resolved version is as intended without the suffix in this case.
skinny85
approved these changes
Apr 17, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
shivlaks
approved these changes
Apr 17, 2020
skinny85
pushed a commit
to skinny85/jsii
that referenced
this pull request
Apr 18, 2020
Removes version suffix from version ranges in `.csproj` files generated by jsii-pacmak. Dotnet doesn't allow version suffixes that start with a number. Version ranges by default don't include prereleases so the resolved version is as intended without the suffix in this case. (cherry picked from commit c6f9a14)
skinny85
added a commit
to skinny85/aws-cdk
that referenced
this pull request
Apr 18, 2020
Version 1.3.0 of jsii-packmak has a bug that makes it impossible to publish .NET packages generated with it to NuGet. It was fixed in aws/jsii#1568, released in version 1.3.1, so change our yarn.lock file to use that latest version (fortunately, we use carets in the dependency declarations on jsii-pacmak).
skinny85
added a commit
to skinny85/aws-cdk
that referenced
this pull request
Apr 18, 2020
Version 1.3.0 of jsii-packmak has a bug that makes it impossible to publish .NET packages generated with it to NuGet. It was fixed in aws/jsii#1568, released in version 1.3.1, so change our yarn.lock file to use that latest version (fortunately, we use carets in the dependency declarations on jsii-pacmak).
skinny85
added a commit
to aws/aws-cdk
that referenced
this pull request
Apr 18, 2020
Version 1.3.0 of jsii-packmak has a bug that makes it impossible to publish .NET packages generated with it to NuGet. It was fixed in aws/jsii#1568, released in version 1.3.1, so change our yarn.lock file to use that latest version (fortunately, we use carets in the dependency declarations on jsii-pacmak).
|
Curious @MrArnoldPalmer what introduced this issue? |
|
@eladb An update to node-semver changed how prerelease suffixes are parsed/output. We bumped semver and changed some code to handle the new behavior where needed. It wasn't apparent that the changed output broke dotnet because it doesn't cause issues until publishing. It's my understanding that it's a valid range and can be used in a .csproj for a binary project, it just can't be published to nuget because it breaks legacy versions of the toolchain. 🤷♂️ |
|
Cool. Thanks for the details. Worth mentioning the root cause in the PR/commit description next time :-) |
Merged
RomainMuller
pushed a commit
that referenced
this pull request
Apr 20, 2020
Removes version suffix from version ranges in `.csproj` files generated by jsii-pacmak. Dotnet doesn't allow version suffixes that start with a number. Version ranges by default don't include prereleases so the resolved version is as intended without the suffix in this case.
RomainMuller
pushed a commit
that referenced
this pull request
Apr 20, 2020
Removes version suffix from version ranges in `.csproj` files generated by jsii-pacmak. Dotnet doesn't allow version suffixes that start with a number. Version ranges by default don't include prereleases so the resolved version is as intended without the suffix in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes version suffix from version ranges in
.csprojfiles generatedby jsii-pacmak.
Dotnet doesn't allow version suffixes that start with a number. Version
ranges by default don't include prereleases so the resolved version is
as intended without the suffix in this case.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.