feat: add autobump script #1335
Conversation
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
4 similar comments
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
MrArnoldPalmer
force-pushed
the
chore/v0.0.0
branch
from
971da5d to
48a9c8a
Compare
MrArnoldPalmer
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
MrArnoldPalmer
force-pushed
the
chore/v0.0.0
branch
2 times, most recently
from
efd4cde to
9cedf03
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -0,0 +1,38 @@ | |||
| #!/usr/bin/env node | |||
There was a problem hiding this comment.
Should we extract this from CDK into a stupid little node module instead of copying and pasting?
There was a problem hiding this comment.
I'm cool with it. Cute name ideas?
| @@ -0,0 +1,20 @@ | |||
| #!/bin/bash | |||
|
|
||
| # Generate CHANGELOG and create a commit (see .versionrc.json) | ||
| npx standard-version --release-as ${version} |
There was a problem hiding this comment.
I am totally fine with moving to standard-version here
MrArnoldPalmer
force-pushed
the
chore/v0.0.0
branch
from
9cedf03 to
59f0619
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
MrArnoldPalmer
force-pushed
the
chore/v0.0.0
branch
from
59f0619 to
5a3bda7
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@MrArnoldPalmer shall we get this merged? |
|
Yeah I'm fixing the tests here to remove version #s instead of aligning before tests. Will do this now. |
MrArnoldPalmer
force-pushed
the
chore/v0.0.0
branch
from
ea65fcb to
80f812a
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
MrArnoldPalmer
force-pushed
the
chore/v0.0.0
branch
from
80f812a to
8fe4771
Compare
MrArnoldPalmer
added
the
pr/do-not-merge
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
MrArnoldPalmer
force-pushed
the
chore/v0.0.0
branch
from
8fe4771 to
f83740e
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -150,6 +150,6 @@ | |||
| "name": "IBaseInterface" | |||
| } | |||
| }, | |||
| "version": "1.1.0", | |||
| "fingerprint": "piaiqNxSj1XkycnXHPRG4697t6DpKGgkya6effAlXKI=" | |||
| "version": "0.0.0", | |||
There was a problem hiding this comment.
Oh cool we no longer need to update tests in version bumps!
There was a problem hiding this comment.
yeah, this does add some complexity to how we build though.
Since tests rely on version numbers not changing, we have to build+test before we run align-version in our build pipeline. Then after running align-version, I'm wary of running package.sh without running build again because if for some reason we changed how align-version works or otherwise do something that could affect the build, then I'd like to know about that failure.
Because of this I actually changed buildspec.yml to do build+test+align-version+build+pack. This seems to be the safest thing for now? @eladb am I being irrational by worrying about this?
There was a problem hiding this comment.
Yes that sounds like what I would do. Not ideal but will work I believe until we figure out some other way...
MrArnoldPalmer
removed
the
pr/do-not-merge
Changes all version numbers in package.json to 0.0.0. to centralize current version to a single location in lerna.json. This removes noise from release PRs.
Adds scripts for aligning package versions to the current version. Changes content of
scripts/bump.shto only bumpNote:
Changing to using
standard-versionfor bumping and changelog from lerna means that all changes are documented in the rootCHANGELOG.mdinstead of within individual package folders.It is possible to continue to use lerna to bump versions, however a couple of issues come up with that.
running
lerna publishorlerna versionrequires you to be attached to a branch. Most CI environments check out an individual commit and are are in a detached state. This means we would have to re-attach somehow.bumping with lerna replaces all of the
"version": "0.0.0"fields in package'spackage.jsonfiles with the newly bumped version. So release PRs still have the version noise.In summay, if we want to have changelogs in package dirs, we probably can't have "v0.0.0" in source code. If we want "v0.0.0" in source code, we should go this way and have a central changelog. Central version = central changelog.
Example Release PR
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.