fix(reflect): failure to load assembly from "npm pack" #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `package.json` file is the result of extracting a tarball obtained from `npm pack`, it may have been processed by `npmjs.com` during publishing, which can cause the `bundleDependencies` property to appear with the value `false`. The null-coalescing (`??`) operator does not rescue this properly and this results in a `TypeError`. This is fixed by using `||` chaining instead of a null-coalescing, which rescues from all falsey values in this case.
skinny85
approved these changes
Dec 13, 2019
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
package.jsonfile is the result of extracting a tarballobtained from
npm pack, it may have been processed bynpmjs.comduring publishing, which can cause the
bundleDependenciesproperty toappear with the value
false. The null-coalescing (??) operator doesnot rescue this properly and this results in a
TypeError.This is fixed by using
||chaining instead of a null-coalescing, whichrescues from all falsey values in this case.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.