fix: Allow Missing Dotnet Version Suffix #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows empty or undefined dotnet versionSuffix field. Removes filter logic from inquirer question prompts to prevent conflicts with validation functions that result in errors being thrown. This seems like a [bug in inquirer](SBoudrias/Inquirer.js#862) when filter returns undefined. Fix broken links in docs. fixes aws#1037
MrArnoldPalmer
added
bug
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
RomainMuller
previously approved these changes
Nov 25, 2019
mergify
bot
dismissed
RomainMuller’s stale review
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
MrArnoldPalmer
deleted the
bugfix/1037-undefined-dotnet-version-suffix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows empty or undefined dotnet versionSuffix field. Removes filter logic from inquirer question prompts to prevent conflicts with validation functions that result in errors being thrown. This seems like a bug in inquirer when filter returns undefined.
Fix broken links in docs.
fixes #1037
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.