fix(aws-cloudwatch-metrics): Add support for annotations #800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Annotations are not supported, even if the documentation states so.
Description of changes
I'm adding support for annotations, and also fixing a typo in the doc.
Checklist
README.md
for modified charts)version
inChart.yaml
for the modified chart(s)Testing
Locally tested with
helm template
as follows:defaults.yaml
with the following content:helm template
against chart folder passing default.yaml as argument as follows:helm template aws-cloudwatch-metrics ~/git/eks-charts/stable/aws-cloudwatch-metrics --namespace amazon-cloudwatch --set clusterName=dev -f defaults.yaml
aws-cloudwatch-metrics/templates/daemonset.yaml
resource.defaults.yaml
helm template
command from step 2, now we can see tolerations in both resource's metadata as well as template's metadata.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.