Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lock for etcd machines if underlying machine is deleted #8906

Closed
vivek-koppuru opened this issue Oct 28, 2024 · 1 comment
Closed
Assignees
Milestone

Comments

@vivek-koppuru
Copy link
Member

If etcd controller is rolling out new nodes for external etcd, there is a deadlock scenario where the lock is waiting for another machine to initialize even though the underlying machine got deleted for a transient issue.

https://github.com/aws/etcdadm-bootstrap-provider/blob/main/internal/locking/locking.go#L58

We need to fix this by checking if the machine exists to be able to remove the lock and have it reconcile normally.

@rahulbabu95
Copy link
Member

aws/etcdadm-bootstrap-provider#41 should fix this deadlock issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants