Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Log Retention in Manifest and/or update it to not be forever in Environments #651

Closed
kohidave opened this issue Feb 11, 2020 · 2 comments · Fixed by #691
Closed
Assignees
Labels
area/manifest Issues about infrastructure-as-code templates. area/svc Issues about services. type/design Issues that are design proposals.

Comments

@kohidave
Copy link
Contributor

kohidave commented Feb 11, 2020

Right now we set the log retention to be forever. This is not good, and is pretty unreasonable.

I think we can update the log groups to have a default retention and then perhaps let customers override it in their manifests.

Just ball parking, but I'm thinking non-prod environments ~ 1 month, prod environments ~3 months?

@kohidave kohidave added area/svc Issues about services. area/manifest Issues about infrastructure-as-code templates. type/design Issues that are design proposals. labels Feb 11, 2020
@iamhopaul123 iamhopaul123 self-assigned this Feb 22, 2020
@SoManyHs
Copy link
Contributor

Default set retention to 1 month. In the future, we'd like to make this configurable.

@SoManyHs
Copy link
Contributor

For custom resources, we should set log retention to be much shorter (1 day? 1 week?), since this is only important for deploying said resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/manifest Issues about infrastructure-as-code templates. area/svc Issues about services. type/design Issues that are design proposals.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants