Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow more/all Docker build options #3466

Open
huanjani opened this issue Apr 14, 2022 · 2 comments · May be fixed by #5838
Open

allow more/all Docker build options #3466

huanjani opened this issue Apr 14, 2022 · 2 comments · May be fixed by #5838
Labels
area/deployment Issues related to deployments type/enhancement Issues that are improvements for existing features.

Comments

@huanjani
Copy link
Contributor

Docker has many options to use with docker build: https://docs.docker.com/engine/reference/commandline/build/#options.
Copilot currently supports only a handful of these flags under image.build:

image:
  build:
    dockerfile: path/to/dockerfile
    context: context/dir
    target: build-stage
    cache_from:
      - image:tag
    args:
      key: value

Copilot users are interested in leveraging other options, for instance, this user, who wants to use --no-cache.
Users could have much more control over their builds if we just injected all key-value pairs as flag-value pairs when running the docker build command. We would have to figure out how to handle flags that don't require values, as well as whether to prohibit any incompatible flags/validate in some way.

Benefits are that users have more flexibility and that Copilot maintainers don't have to keep up with Docker's options.
One drawback is an increased possibility of build failure.

@huanjani huanjani added type/enhancement Issues that are improvements for existing features. area/deployment Issues related to deployments labels Apr 14, 2022
@huanjani
Copy link
Contributor Author

Related: #2090

@wub
Copy link

wub commented Nov 6, 2023

We'd love to use Depot for builds, and opening this up would make that easier.

@mRoca mRoca linked a pull request Jun 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deployment Issues related to deployments type/enhancement Issues that are improvements for existing features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants