Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECS] [Fargate]: Add custom attributes to Cloudmap via ECS service deploy #1119

Open
awsiv opened this issue Oct 15, 2020 · 1 comment
Open
Labels
ECS Amazon Elastic Container Service Proposed Community submitted issue

Comments

@awsiv
Copy link

awsiv commented Oct 15, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Tell us about your request
Enable ECS to add (user provided) custom attributes to Cloudmap

Which service(s) is this request for?
Fargate, ECS, Cloudmap, Appmesh

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
Currently it is not possible to tell ECS service to add custom attributes to Cloudmap instance.
ECS adds certain attributes by default, but I was thinking of adding additional attributes. eg. LIVE = true, so it allows to do some traffic shaping/simulate deregistration delay etc.. by filtering virtual nodes (in App Mesh) based on its attributes. It can be done with external tooling ofc, but then that needs to be made aware of scale-in and scale-out. eg. the tool needs to update Cloudmap after every task is launched. Would be great if this was supported in ECS by default.

As of now, custom attributes for tasks cannot be specified via task definition or during service creation.

Related Issue on aws-cdk: aws/aws-cdk#1711

Are you currently working around this issue?
No

Additional context
Migrating to Appmesh

Attachments
If you think you might have additional information that you'd like to include via an attachment, please do - we'll take a look. (Remember to remove any personally-identifiable information.)

@awsiv awsiv added the Proposed Community submitted issue label Oct 15, 2020
@vibhav-ag vibhav-ag added the ECS Amazon Elastic Container Service label Nov 16, 2020
@Lux-CC
Copy link

Lux-CC commented Mar 29, 2023

We also require a similar for traffic shaping, but also to update the custom attributes after deployment of a task set.

So we would use the EXTERNAL deployment controller, create a new task set (with custom attribute LIVE=false). Then we would send some test traffic, and update the custom attribute to LIVE=true if tests succeed. This way there needs to be no 'smartness' in the client application on where to send traffic to. It would be simply all tasks with a tag LIVE=true.

I'm aware that this can be done using target groups & codedeploy, but we don't use ALBs for ingress on the service but traefik due to a limitation on the number of routing rules of ALBs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ECS Amazon Elastic Container Service Proposed Community submitted issue
Projects
None yet
Development

No branches or pull requests

3 participants