Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recorder Exception When Beginning Segment #81

Closed
mjtieman opened this issue Aug 29, 2018 · 2 comments
Closed

Recorder Exception When Beginning Segment #81

mjtieman opened this issue Aug 29, 2018 · 2 comments
Labels

Comments

@mjtieman
Copy link
Contributor

AWSXRayRecorder is throwing a TypeError when creating a new segment. The exception is being thrown because the recorder is calling should_trace on the sampler, which starting in 2.0 requires sample_req.

Stack trace

should_trace() takes exactly 2 arguments (1 given): TypeError
Traceback (most recent call last):
File "/var/task/src/setup_database.py", line 55, in handler
xray_recorder.begin_segment('setup_database.handler')
File "/var/task/aws_xray_sdk/core/recorder.py", line 208, in begin_segment
decision = self._sampler.should_trace()
TypeError: should_trace() takes exactly 2 arguments (1 given)
@haotianw465
Copy link
Contributor

Thank you for your contribution. I have merged your PR and will prepare a release soon.

@mjtieman
Copy link
Contributor Author

Changes merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants